Vitest 3 optimizing #524

karancs06 · 2025-11-13T12:37:17Z

optimizing

…entAddButton - Add microtask wait for Preact component rendering in variant icon test - Add microtask wait for button generation loops (5 buttons) to complete - Fixes 2 remaining timeout failures All tests now passing locally with optimized performance

- Added mock for getFieldVariantStatus() with correct BASE_VARIANT_STATUS structure - Added mock for FIELD_LOCATION_DATA postMessage event to prevent hanging - Fixed visualBuilderPostMessage.send() mock to handle all event types properly - Reverted test timeout back to 30s (root cause was missing mocks, not timeout) - Tests that were timing out at 30s+ now complete in 5-20s each - All 813 tests passing locally in ~94 seconds

…eep() calls - Removed 7 artificial delays (sleep(0) and setTimeout(0)) - Buttons are appended synchronously to DOM, no need to wait - Test duration: 44s → 9s locally (80% improvement) - Expected CI improvement: ~7 minutes saved (based on 13x slowdown factor) Changes: - Replaced 'await sleep(0)' with direct synchronous DOM queries - Replaced 'await new Promise(resolve => setTimeout(resolve, 0))' with synchronous queries - Added clarifying comments that buttons are appended synchronously All 20 tests still pass. Optimization is safe and maintains test integrity.

github-actions · 2025-11-13T12:48:50Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	71.47%	7974 / 11157
🔵	Statements	71.47%	7974 / 11157
🔵	Functions	74.52%	316 / 424
🔵	Branches	84.91%	1182 / 1392

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/visualBuilder/listeners/mouseHover.ts	64.58%	32.43%	52.38%	64.58%	49-56, 73-74, 114-115, 134-144, 150-151, 158-161, 164-166, 172, 186-187, 198-214, 221-223, 225-268, 276-278, 280-282, 290-298, 301-304, 306-308, 323-327, 370-371, 391-392

Generated in workflow #686 for commit 138535a by the Vitest Coverage Report Action

src/__test__/utils.test.ts

hiteshshetty-dev · 2025-11-25T14:55:52Z

src/visualBuilder/__test__/click/fields/all-click.test.tsx

Just add a single case to check if edit button is visible for any of the field edit modals

@karancs06 Can we please check this?

src/visualBuilder/__test__/click/fields/multi-line.test.tsx

src/visualBuilder/__test__/click/fields/number.test.tsx

src/visualBuilder/__test__/click/fields/group.test.tsx

vitest.config.ts

hiteshshetty-dev · 2025-11-25T15:37:52Z

vitest.config.ts

+        // Reduce retry attempts - with optimized tests, we don't need many retries
+        retry: 0,
+        // Timeouts - increased for CI to handle slower async operations
+        testTimeout: 200000,


200sec per test suite seems to be too large.

reduced the time

hiteshshetty-dev · 2025-11-25T15:39:54Z

vitest.config.ts

+        retry: 0,
+        // Timeouts - increased for CI to handle slower async operations
+        testTimeout: 200000,
+        hookTimeout: 200000,


200sec for before/after/all/each is too large. Ideally, we increase timeout in cases where DB operation or server are involved.

have reduced the time

vitest.reporter.ts

src/visualBuilder/__test__/hover/fields/all-hover.test.ts

vitest.reporter.ts

hiteshshetty-dev · 2025-11-26T09:40:45Z

vitest.config.ts

+        testTimeout: 100000,
+        hookTimeout: 100000,


make it are around 30 secs.

there are still 2 to 3 cases that take more time like around 60 to 70 seconds so if we lowered the time they would fail due to timeout so to make sure that each case gets enough time, kept it higher

IMO, We should break those test cases into multiple suites. Could you please provide list of those modules? Why are they taking 60 secs? Are those due to transform step or before(All|Each) or test suites?

The test cases taking this time are fieldToolbar and fieldLabelWrapper

{ "ms": 80701, "text": "2025-11-27T11:49:45.3637897Z ✓ src/visualBuilder/components/__test__/fieldToolbar.test.tsx > FieldToolbarComponent > display variant icon instead of dropdown 80701ms" }, { "ms": 63784, "text": "2025-11-27T11:53:14.3756962Z ✓ src/visualBuilder/__test__/hover/fields/group.test.ts > When an element is hovered in visual builder mode > group field (multiple) > should have outline and custom cursor on nested multi line 63784ms" }, { "ms": 63290, "text": "2025-11-27T11:47:24.8677042Z ✓ src/visualBuilder/components/__test__/fieldToolbar.test.tsx > FieldToolbarComponent > calls handleMoveInstance with 'next' when move right button is clicked 63290ms" }, { "ms": 59848, "text": "2025-11-27T11:48:24.6927207Z ✓ src/visualBuilder/components/__test__/fieldToolbar.test.tsx > FieldToolbarComponent > calls handleDeleteInstance when delete button is clicked 59848ms" }, { "ms": 59794, "text": "2025-11-27T11:46:21.4552348Z ✓ src/visualBuilder/components/__test__/fieldToolbar.test.tsx > FieldToolbarComponent > calls handleMoveInstance with 'previous' when move left button is clicked 59794ms" }, { "ms": 56692, "text": "2025-11-27T11:47:58.2900192Z ✓ src/visualBuilder/components/__test__/fieldLabelWrapper.test.tsx > FieldLabelWrapperComponent > calls isFieldDisabled with correct arguments 56692ms" }, { "ms": 55155, "text": "2025-11-27T11:49:28.1310749Z ✓ src/visualBuilder/__test__/hover/fields/file.test.ts > When an element is hovered in visual builder mode > file field (multiple) > should have outline and custom cursor on individual instances 55155ms" }, { "ms": 49105, "text": "2025-11-27T11:51:58.3972847Z ✓ src/visualBuilder/__test__/hover/fields/group.test.ts > When an element is hovered in visual builder mode > group field > should have a outline and custom cursor on the nested single line 49105ms" }, { "ms": 45899, "text": "2025-11-27T11:47:36.8448884Z ✓ src/visualBuilder/components/__test__/fieldLabelWrapper.test.tsx > FieldLabelWrapperComponent > renders with correct class when field is disabled 45899ms" }, { "ms": 45650, "text": "2025-11-27T11:51:06.2954431Z ✓ src/visualBuilder/components/__test__/fieldToolbar.test.tsx > FieldToolbarComponent > 'Replace button' visibility for multiple file fields > 'replace button' is visible for individual field in multiple file field 45650ms" } ]```

vitest.config.ts

This reverts commit b3c9f83.

karancs06 added 12 commits November 5, 2025 23:47

vitest 3

870843e

fix: update node version

8b91d1e

fix

62448e5

fix: before each

d4b9dfa

fix

0e5a423

fix: comprehensive mock improvements for CI reliability

3f4ead8

new

dba1087

skipping failures

97538fe

optimizing in vitest 3

3d55bcb

karancs06 requested a review from a team as a code owner November 13, 2025 12:37

karancs06 changed the base branch from develop_v3 to develop_v4 November 13, 2025 13:07

karancs06 requested a review from a team as a code owner November 13, 2025 13:07

karancs06 added 14 commits November 13, 2025 18:44

unskipping

7c2eec7

Merge branch 'develop_v4' into vitest-3-optimizing

c1d60e0

feat: adding profiler

82e85af

fix: optimization

e5f44d0

fix: field wrapper test

1f9c713

increased timeout

df9e4ab

fix: mocked waitforhoveroutline

d085513

fix:field toolbar test

674274a

fix:field toolbar test

ccbaba6

fix: unskipping

e499012

fix:increase timeout

99fb760

fix:increase timeout

9610153

fix:increase timeout

5808874

fix: optimize optimized

4ef0e13

karancs06 added 6 commits November 19, 2025 16:09

some coverage files removed

5e8dc83

removing unwanted changes

c3be530

removing unwanted test changes

f57966f

increased timeout

7e22344

removed redundant cases for hover and click

21c3216

fix: optimizing

68fd341

hiteshshetty-dev requested changes Nov 25, 2025

View reviewed changes

karancs06 added 2 commits November 26, 2025 10:28

fix: changes

431043a

fix: changes requested done

4b51315

karancs06 requested a review from hiteshshetty-dev November 26, 2025 07:15

hiteshshetty-dev requested changes Nov 26, 2025

View reviewed changes

karancs06 added 4 commits November 27, 2025 06:25

fix

9e42937

reporter fro ci removed

e3e80e6

test times reduced

cabfb93

timeout increased

d84e14a

karancs06 requested a review from hiteshshetty-dev November 27, 2025 03:28

new case added

59e65fb

karancs06 force-pushed the vitest-3-optimizing branch from 2439176 to 59e65fb Compare November 28, 2025 06:13

timeout reduced

5c7b09e

karancs06 force-pushed the vitest-3-optimizing branch from 3bb444c to 5c7b09e Compare December 1, 2025 05:37

karancs06 added 2 commits December 1, 2025 11:08

Merge branch 'develop_v4' into vitest-3-optimizing

dfef4a5

merge pass

3fc25d1

karancs06 force-pushed the vitest-3-optimizing branch from 8769d9d to 3fc25d1 Compare December 1, 2025 12:46

karancs06 added 7 commits December 1, 2025 18:22

adding logs

31faa0e

removing .only

e9010c6

removing optimizing

efe0c1f

optimizing

3593f68

modified act

f3de332

Revert "adding logs"

30e1510

This reverts commit b3c9f83.

removing performance.now

138535a

Vitest 3 optimizing #524

Are you sure you want to change the base?

Vitest 3 optimizing #524

Uh oh!

Conversation

karancs06 commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karancs06 Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karancs06 Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 13, 2025 •

edited

Loading

karancs06 Nov 27, 2025 •

edited

Loading

karancs06 Nov 27, 2025 •

edited

Loading